Skip to content

docs(metrics): review API docs & README #2983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 27, 2024
Merged

docs(metrics): review API docs & README #2983

merged 5 commits into from
Aug 27, 2024

Conversation

am29d
Copy link
Contributor

@am29d am29d commented Aug 26, 2024

Summary

Changes

Please provide a summary of what's being changed

This PR overhauls the JSDoc comments on each type, function, class, and method of the metrics utility so that it provides better and relevant info to customers using the API docs or wanting to get contextual info within their IDE.

Please add the issue number below, if no issue is present the PR might get blocked and not be reviewed

Issue number: closes #2375


By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Disclaimer: We value your time and bandwidth. As such, any pull requests created on non-triaged issues might not be successful.

@boring-cyborg boring-cyborg bot added internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) metrics This item relates to the Metrics Utility labels Aug 26, 2024
@pull-request-size pull-request-size bot added the size/L PRs between 100-499 LOC label Aug 26, 2024
@github-actions github-actions bot added do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Aug 26, 2024
Copy link

@am29d am29d self-assigned this Aug 26, 2024
@aws-powertools aws-powertools deleted a comment from github-actions bot Aug 26, 2024
@aws-powertools aws-powertools deleted a comment from github-actions bot Aug 26, 2024
@am29d am29d removed do-not-merge This item should not be merged need-issue This PR needs an issue before it can be reviewed/worked on further labels Aug 26, 2024
@am29d am29d marked this pull request as ready for review August 26, 2024 19:20
@am29d am29d requested a review from a team August 26, 2024 19:20
@am29d am29d requested a review from a team as a code owner August 26, 2024 19:20
Copy link
Contributor

@dreamorosi dreamorosi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for taking over this issue and completing it, I appreciate it.

Great job!

@dreamorosi dreamorosi merged commit 0e5422a into main Aug 27, 2024
22 checks passed
@dreamorosi dreamorosi deleted the am29d/issue2375 branch August 27, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal PRs that introduce changes in governance, tech debt and chores (linting setup, baseline, etc.) metrics This item relates to the Metrics Utility size/L PRs between 100-499 LOC
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maintenance: review API docs & README for Metrics
2 participants